fix(deps): add coal/trimesh to dev extras#528
Merged
Conversation
test_collision.py hard-fails (rather than skipping) when coal isn't installed, and CI's `pip install .[dev]` never pulled it in — the collision extras group existed but wasn't part of dev. Only visible locally where coal happened to already be installed from earlier work. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
TEMPORARY, for CI validation only — revert before merging. See refactor/c-extensions@6dcfc624 for the same change and rationale. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This reverts commit 978127b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.tomlhad acollision = ["coal", "trimesh"]extras group, butdevnever included itpip install .[dev]therefore never installscoal, sotest_collision.pyhard-fails (rather than skipping) on every CI run — invisible locally wherevercoalhappens to already be installed from earlier workcoal/trimeshtodevTest plan
pip install -e ".[dev]"thenpytest tests/test_collision.py -q— 64 passed🤖 Generated with Claude Code